Commit 53808e39 authored by Jelle Zijlstra's avatar Jelle Zijlstra Committed by Zsolt Dollenstein
Browse files

fix crash with long type annotations (#1093)

parent d10b56e6
Loading
Loading
Loading
Loading
+5 −3
Changes for black.py: 5 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -2601,9 +2601,11 @@ def bracket_split_build_line(
            # Since body is a new indent level, remove spurious leading whitespace.
            normalize_prefix(leaves[0], inside_brackets=True)
            # Ensure a trailing comma for imports and standalone function arguments, but
            # be careful not to add one after any comments.
            no_commas = original.is_def and not any(
                l.type == token.COMMA for l in leaves
            # be careful not to add one after any comments or within type annotations.
            no_commas = (
                original.is_def
                and opening_bracket.value == "("
                and not any(l.type == token.COMMA for l in leaves)
            )

            if original.is_import or no_commas:
+11 −0
Changes for tests/data/function_trailing_comma.py: 11 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -4,6 +4,11 @@ def f(a,):
def f(a:int=1,):
    ...

def xxxxxxxxxxxxxxxxxxxxxxxxxxxx() -> Set[
    "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
]:
    pass

# output

def f(a,):
@@ -12,3 +17,9 @@ def f(a,):

def f(a: int = 1,):
    ...


def xxxxxxxxxxxxxxxxxxxxxxxxxxxx() -> Set[
    "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
]:
    pass