Unverified Commit a5bb6e0a authored by Richard Si's avatar Richard Si Committed by GitHub
Browse files

Pin setuptools-scm build time dependency (#2457) 

The setuptools-scm dependency in setup.cfg did not have a version
specified, leading to the issues described in #2449 after a faulty release
of setuptools-scm was published. To avoid this issue in the future, the
last version before that faulty update is now pinned.

Commit history before merge:

* Pin setuptools-scm dependency version (#2449)
* Update CHANGES.md
* Let's pin in pyproject.toml too

Mostly since it's non-build-backend specific configuration and more
widely standardized file. Not sure what benefits pinning in setup.cfg
gives us on top of pyproject.toml but I'd rather not find out during
the release that is supposed to happen today 😉



Co-authored-by: default avatarFiNs <24248249+FabianNiehaus@users.noreply.github.com>
parent 7a093f03

CHANGES.md

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
  trailing comma (#2384)

- Parsing support has been added for unparenthesized walruses in set literals, set

  comprehensions, and indices (#2447).

- Pin `setuptools-scm` build-time dependency version (#2457)



### _Blackd_

pyproject.toml

+4 −1
Original line number Diff line number Diff line
@@ -23,7 +23,10 @@ extend-exclude = ''' 
# NOTE: You don't need this in your own Black configuration.



[build-system]

requires = ["setuptools>=41.0", "setuptools-scm", "wheel"]

# We're pinning setuptools-scm to bugfix versions only because for build-time

# deps having them work on install by default is really important. Especially

# since it's hard for users to work-around the specified build requirements.

requires = ["setuptools>=41.0", "setuptools_scm~=6.0.1", "wheel"]

build-backend = "setuptools.build_meta"



[tool.pytest.ini_options]

setup.cfg

+2 −1
Original line number Diff line number Diff line 
[options]

setup_requires = setuptools_scm
 
setup_requires =

  setuptools_scm~=6.0.1