Commit e6ddb68c authored by Tom Christie's avatar Tom Christie Committed by Jelle Zijlstra
Browse files

Wrap `loop.run_in_executor` up in `asyncio.ensure_future` for reliable...

Wrap `loop.run_in_executor` up in `asyncio.ensure_future` for reliable cross-platform berhavior. (#679)

Closes #494

Task completion should also remove the task from `pending`.

Only replicates on some platforms. (eg. Can replicate on Python 3.7+, with either Windows or whatever default Linux distro Travis uses.)
parent 4a953b72
Loading
Loading
Loading
Loading
+3 −1
Changes for black.py: 3 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -526,12 +526,14 @@ async def schedule_formatting(
        manager = Manager()
        lock = manager.Lock()
    tasks = {
        asyncio.ensure_future(
            loop.run_in_executor(
                executor, format_file_in_place, src, fast, mode, write_back, lock
            )
        ): src
        for src in sorted(sources)
    }
    pending: Iterable[asyncio.Task] = tasks.keys()
    pending: Iterable[asyncio.Future] = tasks.keys()
    try:
        loop.add_signal_handler(signal.SIGINT, cancel, pending)
        loop.add_signal_handler(signal.SIGTERM, cancel, pending)