Unverified Commit f825e7ef authored by Jelle Zijlstra's avatar Jelle Zijlstra Committed by GitHub
Browse files

Remove slow assertion (#1592)

Partial fix for #1581

This assertion produces behavior quadratic in the number of leaves in a line, which is making Black extremely slow on files with very long expressions. On my benchmark file this change makes Black 10x faster.
parent b59a5246
Loading
Loading
Loading
Loading
+0 −2
Changes for src/black/__init__.py: 0 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -4594,8 +4594,6 @@ def append_leaves(new_line: Line, old_line: Line, leaves: List[Leaf]) -> None:
        set(@leaves) is a subset of set(@old_line.leaves).
    """
    for old_leaf in leaves:
        assert old_leaf in old_line.leaves

        new_leaf = Leaf(old_leaf.type, old_leaf.value)
        replace_child(old_leaf, new_leaf)
        new_line.append(new_leaf)