Skip to content
Unverified Commit 113f9fa9 authored by David Hotham's avatar David Hotham Committed by GitHub
Browse files

fix: late binding closure in ApplicationPlugin

B023:  Functions defined inside a loop must not use variables redefined in the loop, because late-binding closures are a classic gotcha.

Here's some sample code approximating the poetry code:
```python
#!/usr/bin/env python3


def one() -> int:
    return 1


def two() -> int:
    return 2


def three() -> int:
    return 3


factories = [one, two, three]

registered = []
for factory in factories:
    registered.append(lambda: factory())

for registered_factory in registered:
    print(f"result is {registered_factory()}")
```
output is
```
result is 3
result is 3
result is 3
```
which is exactly the gotcha that flake8-bugbear's B023 was trying to warn about.

I've applied one of the workarounds that various parts of the internet recommend, and you can verify for yourself if you're so inclined that doing the same in the toy script gives the expected output.
parent 0a5e4b5f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment