Skip to content
Unverified Commit 51a112f1 authored by Colin Dean's avatar Colin Dean Committed by GitHub
Browse files

Improves hash mismatch exception language (#4573)



* Improves wording of exception when calculated hash absent from lockfile and
extracts archive hashing and validation to a separate method

I think this could be further improved by representing the hashes as
a dataclass containing the hash type and the string digest. The types of
hashes would be more robust then instead of hardcoding sha256 here and
in `FileDependency.hash()`. It would also enable enumeration of
hash types of known hashes so that `FileDependency.hash()` could return
a list of hashes based on requested types.

Doing this might alleviate the md5/sha256 problems arising from changes
in poetry-core 1.0.6+ that affect Poetry 1.1.7+ users using Artifactory.

Co-authored-by: default avatarArun Babu Neelicattu <arun.neelicattu@gmail.com>
parent d7982539
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment