Skip to content
Unverified Commit 6ae3c286 authored by Kadir Can Ozden's avatar Kadir Can Ozden Committed by GitHub
Browse files

Fix _remove to catch EnvCommandError instead of CalledProcessError (#10740)

run_pip() wraps CalledProcessError inside EnvCommandError, so the
except CalledProcessError handler in _remove() was dead code.  If
pip exited non-zero with 'not installed' in its output, the
EnvCommandError would propagate uncaught to _execute_operation,
which treats it as a fatal error and aborts the entire installation.

This matters when removing a package that was already uninstalled
externally — e.g. via pip directly — while Poetry is performing
an update.
parent ad9ab008
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment