Skip to content
Unverified Commit a17f1ba3 authored by Evan Rittenhouse's avatar Evan Rittenhouse Committed by GitHub
Browse files

Added canonicalize_name() to console/commands/init.py (#5076)

* Added canonicalize_name() to console/commands/init.py

* Removed unnecessary helper function calls

* Fixed capitalized package bug on poetry init

Used canonicalize_name to standardize the names of all packages in
poetry init with interactive dependencies. Given its importance, added a
test_canoncalize_name() test to tests/utils/test_helpers.py

* Split out _get_choice_list to a separate function

For testing purposes

* Tests working with canonicalized_name assigned outside of _generate_choice_list()

* Changed test_generate_choice_list

Parameterized a _generate_choice_list_packages fixture in order to call
the test with both > 10 and < 10 cases, verifying that output is <= 10
and the package_name has the desired package first in choices

* Added output message if choice_list is truncated

Also added cases for truncation and non-truncation in
test_generate_choice_list to ensure the message is printed in only the
correct cases

* Removed info_string calls

Moved info_string generation logic out of init._generate_choice_list

* Removed type hint for info_string
parent c1c74b98
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment